dw_dev_training | Recent Entries

It's time for another question thread!

The rules:

- You may ask any dev-related question you have in a comment. (It doesn't even need to be about Dreamwidth, although if it involves a language/library/framework/database Dreamwidth doesn't use, you will probably get answers pointing that out and suggesting a better place to ask.)
- You may also answer any question, using the guidelines given in To Answer, Or Not To Answer and in this comment thread.

pauamma

purplecat

I'm about to push my latest bug fix to github. While I've been working on this bug there's been some changes to the main develop branch so, obviously, I want to merge these into my branch before I push my code and submit a pull request.

Now I recall that in the past I've been asked to clean up the log after doing this but I've forgotten the process for achieving that. If someone could post an idiots' guide in the comments that would be really useful!

purplecat

A while back I tackled a bug in which icons could not have "0" as a keyword. The problems were all caused by the fact that perl treats "0" as false, so a lot of checks for the existence of a keyword on the icon were failing.

Having fixed that particular problem a host of others have been revealed when someone tries to use an icon with a 0 keyword and I've been working through these.

At present, in my dreamhack, it is possible to make a post with a 0-keyword-icon selected and view that post. However if you then try to edit the post the icon gets replaced by the default icon, and if, in the edit page, you attempt to select a 0 keyword icon, it doesn't get attached to the post in the database.

I'm tearing my hair out over this because I can not identify how icon selection differs in the edit form from the post form. The bug appears both using the new and old versions of the post form so I'm assuming it isn't in the javascript or template toolkit and I'm going cross-eyed grepping the codebase.

One of my problems is I'm not even entirely clear where may be a good point to start inserting some "warn" statements, or how to simulate post editing within the test suite.

Any hints, suggestions or pointers much appreciated.

pauamma

kaberett

Bug 4960 is about improving accessibility of the site, particularly in long comment threads. It may involve a little rummaging with S2, but while it's not quite a one-line fix it should be pretty easy (testing will likely take longer than coding!), and it will have a big impact on usability.

I'm going to add it to the "doing the two-step" section of the beginners' bugs masterlist, but I felt like this one deserved its own post as well. :-)

Claim it on Bugzilla to make it your own, then show up in IRC or PM me if you'd like cheerleading/guidance/etc!

pauamma

kaberett

Over in

dw_dev,

mark has announced a bug bounty in August -- the first 20 pull reqs to get submitted (not reviewed, or accepted!) get gift cards. Doesn't matter how big or small the fix is -- so I think this is a good time to remind y'all that I keep an up-to-date babydev bait masterlist as a sticky post in this comm.

And as another reminder -- if you are in any sense intimidated by Dreamhacks and Github, the IRC channel is always full of people who are willing to help -- and I personally am 100% okay with being point-of-contact, to talk you through things or to point you at people who Know The Relevant Stuff. You can always private message/query me in IRC, and I'll get it eventually; I'm in the UK but on a slightly weird sleep schedule, if you want to time catching me.

Happy hunting! :-)

meludame

Hi! I'm meludame, I usuablly dabble in styles-related bug and this is the bug write-up I did for my latest.

Description:

Some of the older DW styles do not print the page subtitle even though the option is there on the customize style page. Styles that are concerned are the following:

Brittle, Negatives (doesn't print the title either)
Skittlish Dreams, Sunday Morning, Transmogrified

Proposed fix:

Edit the layouts concerned to add in the missing feature. Edit the relevant portion of the CSS to make the change as unobtrusive as possible for the user of said styles.

References files:

Formatted source of core2,
momijizukamori's giant list of core2 variables,

Files edited:

For each layout, styles/$layoutname/layer.s2 (in either dw-free or dw-nonfree).

( Bug Diary )

Thanks:

I would like to thank the members of #dreamwidth and in particular (but non-exhaustively) sophie, kaberett, geekosaur, momijizukamori and ninetyd for their coaching, cheering and reassurances as I worked my way through this bug. Y'all are amazing :)

Note: Another copy of this entry lives in my journal.

Current Mood: accomplished

pauamma

Again, it's been way too long since the last question thread (why didn't anyone poke me?) so let's have another one!

The rules:

- You may ask any dev-related question you have in a comment. (It doesn't even need to be about Dreamwidth, although if it involves a language/library/framework/database Dreamwidth doesn't use, you will probably get answers pointing that out and suggesting a better place to ask.)
- You may also answer any question, using the guidelines given in To Answer, Or Not To Answer.

And since no one poked me this time either: do these still serve a useful purpose? And how often would you like to see them, if at all?

misskat

A quick reminder: if you're logging a bug that's from a Support request, or has something to do with the Support board, please tag it from-support. Similarly, if you're working on or see an older bug that was filed due to a Support request, please add the tag.

Thanks!

swaldman

Does anybody have time to do a quick rundown on how error handling should be done in DW, going forward?

There are a number of different ways of doing things within the codebase at present. I've tended to adopt LJ::throw for new stuff because it seemed comprehensible(!), but Mark has recently said in a review "I... don't think we use LJ::Error anywhere useful anymore. It's pretty old.". (given where the comment was made I assume that it referred to a LJ::throw statement, which I imagine must be part of a LJ::Error package)

So I'm wondering what best practice is now, and thus what we should do in new code?

Thanks

Current Mood: curious

momijizukamori

Bug 5175 - not all layouts display the journal subtitle. I looked at the code, and it involves adding one line of code to each of the layouts in question. I did not do a full write-up on the bug, but I can point someone to what it is if they would like! This is a good one if you want some very simple interaction with S2 and core2 functions (extremely simple, I promise).

denise

mark just filed two bugs that have to do with fixing warnings and errors in the logs. Two of 'em are probably a bit more involved, but bug 5181: Calling "prop" on undefined value is a very good starter bug!

( Hints if you want/need 'em )

As always, holler if you need more guidance!

kaberett

Hello lovelies!

I've just done some maintenance on my pet masterlist of bugs for new devs, including sticking all the recent additions into it - go have a rummage, see if anything takes your fancy :-) Feel free to ask there (or here!) for more detail on any of them!

deborah

<sheepish>I just noticed that we don't have alt text on the dreamwidth logo.</sheepish>

If somebody could pick up bug 5173, it would be a very nice small bug to get started (you just have to find where in the code the image is created, and add the alternative text).

jeshyr

I'd really like to work on more testing bugs ... but I'm not sure where to start. I really enjoyed looking at all the *.t test files when I did Bug 5116 and boilerplated all the test files.

Currently in Bugzilla we only have two bugs that are listed under Testing:

Bug 4439 - fix test suite so it can be run safely against the db.
Bug 3525 - Investigate separating tests files from main files

The second of those is from 2011 and I think it would be obsoleted by Bug 4439 anyway, because the rationale for separating is that we don't accidentally screw up prod's database?

In any case they look too big and scary for me to start with, and I know that

uncanny_kate and

karelia and others have discussed working on tests too, so I want to make sure I'm not doing stuff that's already been done or obsoleted.

Is there anywhere else I could start with doing testing things??

ninetydegrees

~~http://bugs.dwscoalition.org/show_bug.cgi?id=4151: easy fix is literally changing one line in core2.s2 as explained in the comments. How's that for a non-scary style thing?~~

http://bugs.dwscoalition.org/show_bug.cgi?id=5160: cleanup! If you're into ~~time-travelling~~ removing a few *very* old lines of code this one's for you.

Profile

Dreamwidth Development Training

September 2022

S	M	T	W	T	F	S
				1	2	3
4	5	6	7	8	9	10
11	12	13	14	15	16	17
18	19	20	21	22	23	24
25	26	27	28	29	30

Syndicate

Page Summary

Active Entries

Style Credit

Style: Denim for Basic Boxes by branchandroot
Resources: On the Down Low

Expand Cut Tags

No cut tags

Page generated Jun. 14th, 2025 10:15 pm

Dreamwidth Development Training

Recent Entries

Question thread #16

Question thread #15

Question thread #14

Git Logs and Merging develop into a branch

Difference between icon selection when posting and when editing a post

Question thread #13

Question thread #12

Babydev bait: kab's most-wanted

Question thread #11

August bug bounty!

Bug 5175: Some styles need subtitles

Description:

Proposed fix:

References files:

Files edited:

Thanks:

Question thread #10

Bugzilla Tagging from-support

Error handling - help please?

More styles-related newbie-dev bait

babydev bait!

Babydev bait masterlist bump

small bug, good for someone new to the code

Testing Times!

Two bugs for Newbie Devs

Profile

September 2022

Links

Syndicate

Most Popular Tags

Page Summary

Active Entries

Style Credit

Expand Cut Tags