![[site community profile]](https://www.dreamwidth.org/img/comm_staff.png){kind=small}
![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
ninetydegreesHi! I would love to patch the style I've submitted but I don't know if it needs @media $medium_media_query and @media $large_media_query and if so, where to put them exactly. Could someone explain our breakpoint system to me?
ninetydegrees
Bug 5175: Some styles need subtitles
Jul. 24th, 2013 10:53 pmmeludameHi! I'm meludame, I usuablly dabble in styles-related bug and this is the bug write-up I did for my latest.
Description:
Some of the older DW styles do not print the page subtitle even though the option is there on the customize style page. Styles that are concerned are the following:
- Brittle, Negatives (doesn't print the title either)
- Skittlish Dreams, Sunday Morning, Transmogrified
Proposed fix:
Edit the layouts concerned to add in the missing feature. Edit the relevant portion of the CSS to make the change as unobtrusive as possible for the user of said styles.
References files:
- Formatted source of core2,
- momijizukamori's giant list of core2 variables,
Files edited:
- For each layout, styles/$layoutname/layer.s2 (in either dw-free or dw-nonfree).
( Bug Diary )
Thanks:
I would like to thank the members of #dreamwidth and in particular (but non-exhaustively) sophie, kaberett, geekosaur, momijizukamori and ninetyd for their coaching, cheering and reassurances as I worked my way through this bug. Y'all are amazing :)
Note: Another copy of this entry lives in my journal.
More styles-related newbie-dev bait
Jul. 10th, 2013 10:31 pmmomijizukamoriBug 5175 - not all layouts display the journal subtitle. I looked at the code, and it involves adding one line of code to each of the layouts in question. I did not do a full write-up on the bug, but I can point someone to what it is if they would like! This is a good one if you want some very simple interaction with S2 and core2 functions (extremely simple, I promise).
afunaHere's the process to take an existing theme layer and convert it into patch form (with all the fluff and trimmings to make it work on the customize page, have proper credit, etc).
To add a theme layer to an existing style, you need to edit two files:
bin/upgrading/s2layers/$layoutname/themes.s2 (or themes-local.s2)
cgi-bin/LJ/S2Theme/$layoutname.pm (or $layoutname_local.pm)
( in detail )
This entry is purely about generating patches from a layer which is already s2-ified, so I won't cover the conversion from a stylesheet to a theme layer. If you need it, see the tutorial for S2 property conversion, which is thoroughly amazing. :)
Hopefully you won't need to do that yourself (the task is time-consuming, but not very complicated,so it's perfect for when you have plenty of time on your hands, but not much brainpower to spare). Let's just move on past it; I'll assume that either the theme came ready-converted, or that you did the conversion on your own.
So, you'll basically end up editing five files:
bin/upgrading/s2layers.dat
bin/upgrading/s2layers/$layoutname/layout.s2
bin/upgrading/s2layers/$layoutname/themes.s2
cgi-bin/LJ/S2Theme/$layoutname.pm
cgi-bin/LJ/S2Theme.pm
( in detail )
Other things: images for layouts go under: htdocs/stc/$layoutname/imagename.png, etc. (under stc so that we can access them as relative urls from stylesheets, though in practice, we've been setting them as absolute URLs in properties by using variables, etc)
And uhh. I guess that's it!
Edit: 10/01: fixed a few errors, clarified a few instructions, courtesy ofzvi
Adding a theme layer to an existing style
To add a theme layer to an existing style, you need to edit two files:
bin/upgrading/s2layers/$layoutname/themes.s2 (or themes-local.s2)
cgi-bin/LJ/S2Theme/$layoutname.pm (or $layoutname_local.pm)
( in detail )
Adding an entirely new style from a theme layer
This entry is purely about generating patches from a layer which is already s2-ified, so I won't cover the conversion from a stylesheet to a theme layer. If you need it, see the tutorial for S2 property conversion, which is thoroughly amazing. :)
Hopefully you won't need to do that yourself (the task is time-consuming, but not very complicated,so it's perfect for when you have plenty of time on your hands, but not much brainpower to spare). Let's just move on past it; I'll assume that either the theme came ready-converted, or that you did the conversion on your own.
So, you'll basically end up editing five files:
bin/upgrading/s2layers.dat
bin/upgrading/s2layers/$layoutname/layout.s2
bin/upgrading/s2layers/$layoutname/themes.s2
cgi-bin/LJ/S2Theme/$layoutname.pm
cgi-bin/LJ/S2Theme.pm
( in detail )
Other things: images for layouts go under: htdocs/stc/$layoutname/imagename.png, etc. (under stc so that we can access them as relative urls from stylesheets, though in practice, we've been setting them as absolute URLs in properties by using variables, etc)
And uhh. I guess that's it!
Edit: 10/01: fixed a few errors, clarified a few instructions, courtesy of
zvi
