QFaN: how thorough are redirects supposed to be?

[ninetydegrees]

The case: bug #2398 is about moving editpics to editicons. If I have a look at the patch submitted for a similar bug (bug #2396) it seems simple enough (and something a baby like me managed to actually patch \o/).

The question: should the 'renaming' be more thorough for this bug? In other words, should all references to editpics in other files such as allpics.bml and /site/index.bml be changed and should related files such as editpics.css and editpics.js be 'renamed' too? Or should we trust the redirect to make everything work smoothly and not bother?

Comments

[afuna]

Oops, you're working directly in dw-free/dw-nonfree, I didn't realize! In that case, edit the version of the file under cvs/bml/lib/Apache/BML.pm, then.

Hmmmmmmmm. Yes you can fix those as well, just make sure that they're also fixed in whatever processes the form (likely something that looks for $POST{editpics$suffix} somewhere down the page)

[ninetydegrees]

Ok I'm feeling dumb now. In dw-free, cvs/bml/lib/Apache/BML.pm doesn't exist. I only have dw-free/cvs/multiccvs.pl.

[afuna]

Ah! Sorry, no, that's my fault for not being clear. Go to $LJHOME/cvs/bml/lib/Apache/BML.pm

($LJHOME/cvs contains dw-free, dw-nonfree, and a bunch of other folders, including bml)

[ninetydegrees]

Ah my bad! I knew that but couldn't figure out to make a patch: I kept trying to create a Mercurial repo in the wrong folder (cvs instead of bml because I didn't see .hg was there).

[ninetydegrees]

Yes you can fix those as well, just make sure that they're also fixed in whatever processes the form (likely something that looks for $POST{editpics$suffix} somewhere down the page)

Hmm. I don't see anything like this, no.

[afuna]

Durrrr. My bad again. I was skimming and I thought it was something like <input ... >, and instead it's the page that the form is supposed to post to! So um, yeah, heh. Just change those to editicons.

[ninetydegrees]

Well, I have that one too:

<input type="hidden" id="go_to" name="go_to" value="editicons$suffix$getextra" />

[afuna]

Hmmm, I'm not absolutely certain what that is for, but it looks like a reference pointing back to the current page. That is to say: so yeah, edit it.

[ninetydegrees]

Ok so I had everything edited in this file. I'm going to regenerate the patch though since some bml files have been modified since. Thanks for going through this with me with your usual patience and graciousness.

[afuna]

It was my pleasure :)

*salutes*