QFaN: how thorough are redirects supposed to be?

[ninetydegrees]

The case: bug #2398 is about moving editpics to editicons. If I have a look at the patch submitted for a similar bug (bug #2396) it seems simple enough (and something a baby like me managed to actually patch \o/).

The question: should the 'renaming' be more thorough for this bug? In other words, should all references to editpics in other files such as allpics.bml and /site/index.bml be changed and should related files such as editpics.css and editpics.js be 'renamed' too? Or should we trust the redirect to make everything work smoothly and not bother?

Comments

[ninetydegrees]

Well, I have that one too:

<input type="hidden" id="go_to" name="go_to" value="editicons$suffix$getextra" />

[afuna]

Hmmm, I'm not absolutely certain what that is for, but it looks like a reference pointing back to the current page. That is to say: so yeah, edit it.

[ninetydegrees]

Ok so I had everything edited in this file. I'm going to regenerate the patch though since some bml files have been modified since. Thanks for going through this with me with your usual patience and graciousness.

[afuna]

It was my pleasure :)

*salutes*