QFaN: how thorough are redirects supposed to be?

[ninetydegrees]

The case: bug #2398 is about moving editpics to editicons. If I have a look at the patch submitted for a similar bug (bug #2396) it seems simple enough (and something a baby like me managed to actually patch \o/).

The question: should the 'renaming' be more thorough for this bug? In other words, should all references to editpics in other files such as allpics.bml and /site/index.bml be changed and should related files such as editpics.css and editpics.js be 'renamed' too? Or should we trust the redirect to make everything work smoothly and not bother?

Comments

[afuna]

Ah! Sorry, no, that's my fault for not being clear. Go to $LJHOME/cvs/bml/lib/Apache/BML.pm

($LJHOME/cvs contains dw-free, dw-nonfree, and a bunch of other folders, including bml)

[ninetydegrees]

Ah my bad! I knew that but couldn't figure out to make a patch: I kept trying to create a Mercurial repo in the wrong folder (cvs instead of bml because I didn't see .hg was there).