Displaying the people who posted comments!

[randomling]

Hi guys,

I'm working on bug 4242 - including the poster of the comment in the preview page (helpful for people who might be posting comments as the wrong user, not noticed they're not logged in, wanted to use their OpenID, whatever).

I've managed to display the commenter's username - as long as they're actually a logged-in user of DW. However, anon and OpenID comments break the preview page now, because I haven't figured out how to display anon and OpenID there yet.

I was hoping to take my lead from the actual comments pages of entries, which show them just fine. But while I can find the page that deals with the comments page (/htdocs/talkread.bml) I can't actually find the place where it displays the username. It's a forest of code!

I wonder if anyone could show me the place where that happens? A copy/paste, line number, or thing to search the file for would really help me to get started.

Thanks!

ETA: Look, denise, I asked for help!

Comments

[momijizukamori]

Hmm. Do you know what styles the preview page? I can point you to the S2 code for username printing (which hopefully I will be replacing talkread with very soon), but I don't know the bml/tt version

[randomling]

Yeah, it's a .bml page.

[momijizukamori]

Curses. I'm no help then XD

[denise]

You should be able to do something like (pseudocode, off the top of my head and might be wrong)

check if $remote is a user object ? $remote->ljuser_display : show as anonymous

(ljuser_display is almost certainly the name of the function but double check that. it does handle OpenID though)

You are probably going to be looking at weblib.pl for what builds the comment headers but it might be somewhere in Talk.pm instead.

[randomling]

Huh. I'm using $remote->ljuser_display and it's breaking horribly with OpenID. Or at least I think it is. I will check again...

Thanks for the tips!

[denise]

Weird! I could've sworn it knew what to do with those.

Meanwhile, I've skim-read the code a bit, and I think you are better off looking in Talk.pm -- if you get stuck and nobody else can point you more closely, ping me tomorrow and I'll try to turn up something more specific.

[foxfirefey]

I am positive ljuser_display knows what to do with OpenID, so some more description on the problem being encountered would help!

[randomling]

Yeah, I don't know quite what was happening with my code before, but it's working now! Just need to test it up with an anon comment...

Thanks, both!

[yvi]

If it helps any, the jungle that is talkread/talkpost/talkpost_do/Talk.pm/weblib.pl is really not easy to navigate...