Including changes to config files in patches

[purplecat]

Still working on Bug 2152. The bug involves allowing people to have multiple stickies and the number they can have depends upon their account type. Adding this feature is going to involve a new config setting where someone sets the numbers of stickies allowable for each account type. However I've done the whole protect your configs from updates thing which means the new config settings aren't showing up in the patch files I create.

Should I just document the extra settings needed in the files? especially since the actual numbers associated with each account type aren't particularly important to the code and should probably be decided upon by the powers that be separately from the actual patch? or should I include some default values in the patch and, if so, what is the best way to go about getting these picked up by cvsreport.pl -d?

Comments

[alierak]

I would say include them in the patch; config settings should have defaults for new installs, at least. It sounds like you would need to apply your changes under cvs/dw-free/etc to have them show up in the patch (but changes here won't show up in your running dreamhack, so don't bother doing this until you're making a patch I guess).

[purplecat]

OK thanks!

[fu]

alierak has already covered why you should -- just to add some input, the config files in our production environment are protected in the same way as what you linked to, so you don't need to worry about things needing to be decided by TPTB -- we'll have to do it anyway.

The other thing, you might want to put it into either doc/config.pl.txt, or in LJ::Global::Defaults if you're really not sure where they should go.