kaberett: A sleeping koalasheep (Avatar: the Last Airbender), with the dreamwidth logo above. (dreamkoalasheep)
kaberett ([personal profile] kaberett) wrote in [site community profile] dw_dev_training2013-05-13 02:10 am
Entry tags:

Babydev bait of the week: add sites to whitelist for embedding

This is a threefer: if you can do it for bug 4970, you can also do it for 5011 and 4959!

Thoughts? Queries? Takers? ♥
azurelunatic: Vivid pink Alaskan wild rose. (Default)

[personal profile] azurelunatic 2013-05-13 02:58 am (UTC)(link)
This is a common enough task that it should have a wiki page. I've started one, with files that Fu touched in the Goodreads embed commit:

http://wiki.dwscoalition.org/wiki/index.php/Adding_Embed_Whitelist_Items
azurelunatic: Vivid pink Alaskan wild rose. (Default)

[personal profile] azurelunatic 2013-05-13 07:04 am (UTC)(link)
What else should go there?
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)

[personal profile] fu 2013-05-13 07:20 am (UTC)(link)

Hmm. I think that's pretty much it. EmbedWhitellist.pm seems pretty straightforward to me (in the sense of -- edit host_path_match, that's all you need most of the time), and so is t/embed-whitelist.t (in the sense of -- add a quick san check)

I also usually make an entry with the embed to double-check but it's not really needed because of t/embed-whitelist.t. ;)

azurelunatic: Vivid pink Alaskan wild rose. (Default)

[personal profile] azurelunatic 2013-05-15 09:45 am (UTC)(link)
*twinkles*