QFaN: how thorough are redirects supposed to be?

[ninetydegrees]

The case: bug #2398 is about moving editpics to editicons. If I have a look at the patch submitted for a similar bug (bug #2396) it seems simple enough (and something a baby like me managed to actually patch \o/).

The question: should the 'renaming' be more thorough for this bug? In other words, should all references to editpics in other files such as allpics.bml and /site/index.bml be changed and should related files such as editpics.css and editpics.js be 'renamed' too? Or should we trust the redirect to make everything work smoothly and not bother?

Comments

[triadruid]

Would it make sense to add a second hook under the new title, or at least a comment line with the new keyword? I expect institutional memory will eventually fade, and someone will forget to grep for both 'editpics' AND 'editicons'...

[afuna]

Hmmm, thinking, thinking. I'm worried that it will complicate things. It may be easier to go through the hooks at some later point and rename them so they make sense (or document the hell out of them), so any announcements of incompatibilities could be done in one go, rather than piecemeal.