Another dumb question from a newbie: multiple bugs on the same page = 1 bug?

[ninetydegrees]

I keep finding bugs on Manage Comments. I've already filed three and I could file two more. I'm afraid it's getting a little ridiculous. What's the policy in this case? Should I file the new bugs independently anyway, edit the last one and give it a vaguer title? What?

BTW are there any guidelines somewhere for using Bugzilla? I don't get when it's ok to reopen a bug and when it isn't for example.

A: Reopen when there is a problem with the fix itself: it didn't fix the bug.

Comments

[janinedog]

If all of the bugs are small, easy to fix, and not likely to result in major issues if the fix goes wrong (i.e. none of them involve re-working the page in a major way), it's probably fine to keep them in one general bug. In other words, you just want to make sure that whoever is going to fix the bugs can do so in one patch without that patch being completely overwhelming or confusing.

Hopefully that helps a bit. It never hurts to make the bugs separate, so if you're not sure, just do that. :)

[ninetydegrees]

Hmm. I think I'll put the remaining issues into one bug then since I'm pretty sure I can fix the other ones. Thanks!

Also, I love small bugs, they're nice for babies like me.

Now on to figure out the difference between is_person and is_individual...

[foxfirefey]

If I remember,

is_person returns true if the account is a personal DW account.

is_individual returns true if the account is a personal or OpenID DW account.

[ninetydegrees]

Thank you!

I didn't know which was what. Hmm. Maybe I'll be able to fix that other bug then... Decisions, decisions...

[ninetydegrees]

Are there any other is_ e.g. for communities?

I'm trying to see how one would say "is a personal account or a community" because OpenID users can't receive comments, right? Are there any other type of possible accounts too?

[foxfirefey]

Yes!

There are the following functions, mostly self explanatory:

is_community
is_identity -- returns true if the user is an OpenID identity
is_official
is_paid
is_perm
is_redirect -- this user redirects to another user, like with renames
is_syndicated -- for a feed account

It looks like there's no function that combines both, but you can use two functions by using an or (||) in your if statement:

if ( $u->is_personal || $u->is_community ) {
  # This if statement works for personal journals or communities
}

[denise]

You can see all of the available is_* in User.pm.

[ninetydegrees]

So obvious and I've been looking for this file for ages. Thank.you.so.much.

[janinedog]

Oh, and as for your second question, I have no idea if there are official guidelines (if there are, they're probably in the wiki somewhere), but you can reopen a bug if that bug can no longer be considered "fixed". Reasons could be: the fix that was made does not actually fix the bug, or something else cropped up that is directly related to the bug and/or the fix for the bug which needs to be fixed too (e.g. the fix caused another bug). Those are the main reasons to reopen, I'd say.

[ninetydegrees]

Hmm. One bug I noticed was something that seems to have been overlooked during the implementation of something (bug 1983 and bug 1881). Denise said 'new bug' so I'm not sure I understand what is considered as related and what isn't.

[yvi]

Maybe she just knows that if I get another bug reopened I will cry big tears ;)

No, seriously, that was a tricky case. If you had reopened it then it would be assigned to me (I think) and so if you wanted to fix it yourself it was best to open a new one instead of going through the trouble of you asking and then me having to say yes.

Thanks for fixing it!

[ninetydegrees]

:) *hugs*

I didn't want to fix it because I didn't know I could but it turned out I think I did (it hasn't been reviewed yet) and found other issues while testing the patch so it's all good in the end.

[janinedog]

Hm, I think that's a borderline case, and I think if you had reopened, it would have been fine (but since Denise said to open a new bug, you do that instead). It is directly related, but it also isn't something that makes the original change null or bad. There will always be cases where it's not obvious if it should be reopened or not, and this is one...I probably would have for this, but both options are definitely valid.

[denise]

I sort of flip a coin. That one was borderline; I said new bug because it wasn't *really* a problem with how the thing was implemented, since (IIRC) it was a problem before that patch, too, but I was working quickly and I might've been wrong.

Generally, if it's something that's a problem with the actual fix itself (it didn't actually fix it, it introduced a new bug, etc) I'll reopen, and if it was something that was left out of the spec of the original item I'll say new bug. It's fuzzy though.

[ninetydegrees]

Well, you've made it far less fuzzy. Thanks again.

[azurelunatic]

Strikes me as a lot of this could be condensed for the 'intro to dev' on the wiki, possibly.