ninetydegrees: Art: self-portrait (Default)
ninetydegrees (90d)☕ ([personal profile] ninetydegrees) wrote in [site community profile] dw_dev_training 2010-02-23 09:33 pm (UTC)

So thorough is good. Thanks!
If you don't mind, I have a few more questions as there are some things left I'm unsure about.

I get 'editpics' in files I have no idea what they're really for:

cgi-bin/Apache/BML.pm
cvs/bml/lib/Apache/BML.pm
cvs/bml/test/fake_root/bml-test.correct
cvs/bml/test/fake_root/bml-test.bml
cvs/bml/test/fake_root/global.look

Should they be patched too?

In editpics.js there is a function called editpicsInit. Should it be renamed?
In editpics.css there is a class called EditPicsUserpic. Same question. Both are used in editpics.bml and only there if I'm not mistaken.

In editpics.bml, there are also a few lines I'm unsure about:

            if ($inline .= LJ::Hooks::run_hook("cprod_inline", $u, 'EditPics')) {
                    if ($inline .= LJ::Hooks::run_hook("cprod_inline", $u, 'EditPicsMax')) {


Should I change these?

In en.dat, there are some strings which use editpics in their names. Most of them seem unused but this one is:

cprod.editpics.text7.v1=You've reached your limit of [[num]] userpics.

Should they be renamed as well?

Post a comment in response:

This account has disabled anonymous posting.
If you don't have an account you can create one now.
HTML doesn't work in the subject.
More info about formatting